🎨 Tracing: instrument logs and ensure traces are propagated through asyncio.Queues
#6857
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6857 +/- ##
==========================================
+ Coverage 88.37% 88.53% +0.16%
==========================================
Files 1567 1236 -331
Lines 61463 52888 -8575
Branches 1994 1138 -856
==========================================
- Hits 54319 46826 -7493
+ Misses 6813 5856 -957
+ Partials 331 206 -125
Continue to review full report in Codecov by Sentry.
|
bisgaard-itis
requested review from
GitHK,
matusdrobuliak66,
pcrespov and
sanderegg
as code owners
pcrespov
approved these changes
Nov 29, 2024
Member
pcrespov
left a comment
pcrespov
left a comment
There was a problem hiding this comment.
the idea looks very promising
Left some suggestions
GitHK
approved these changes
Nov 29, 2024
matusdrobuliak66
approved these changes
Nov 29, 2024
|
17 tasks
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What do these changes do?
trace_idandspan_idwill now be printed in the logs. This will mean we can search for thetrace_idin Graylog to see the logs associated with a single trace (probably requires updating a setting in Graylog). A future goal is to connect/integrate the prometheus metrics (via exemplars), logs and traces as described in Improve/Setup osparc-simcore observability #6831, so we can navigate through our different observation tools using the Grafana UIrun_sequentially_in_context(this should propagate the traces you mentioned were missing in Jaeger @sanderegg: Ensure the httpx client indirector-v2(used to contact thecatalog) is instrumented with opentelemetry. #6822)Related issue/s
trace_ids to logging and ensure all httpx clients are instrumented. #6835director-v2(used to contact thecatalog) is instrumented with opentelemetry. #6822How to test
Dev-ops checklist